Warn when neff ratios exceed 1#495
Closed
utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
Closed
Conversation
Member
|
With Stan when ESS (n_eff) exceeds the posterior sample size it is actually often a favorable sign, not a bad one, so I don't actually think we need a warning here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 35 35
Lines 5857 5862 +5
=======================================
+ Hits 5779 5784 +5
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #494
Summary
validate_neff_ratio()now issues anrlang::warn()when any values are greater than 1expect_warning()assertion